Skip to content

[https://nvbugs/5612529][fix] Fix transferAgent_test #8710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chuangz0 merged 1 commit into from
Oct 29, 2025
Merged

[https://nvbugs/5612529][fix] Fix transferAgent_test #8710

chuangz0 merged 1 commit into from
Oct 29, 2025

Conversation

@chuangz0
Copy link
Collaborator

@chuangz0 chuangz0 commented Oct 28, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Tests
    • Updated test execution order for transfer agent synchronization scenarios to align submission timing with notification events.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chuangz0
transferAgent_test
6523663 
Signed-off-by: Chuang Zhu <[email protected]>
@chuangz0 chuangz0 requested a review from Shixiaowei02 October 28, 2025 05:54
@chuangz0
Copy link
Collaborator Author

chuangz0 commented Oct 28, 2025

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

📝 Walkthrough

Walkthrough

The pull request reorders method invocations in SyncMessage test cases, moving notifySyncMessage calls to occur after submitTransferRequests submissions. This changes the relative timing of transfer request initiation and sync message notification events in the test execution flow.

Changes

Cohort / File(s) Summary
SyncMessage test reordering
cpp/tests/unit_tests/executor/transferAgentTest.cpp		 Moved notifySyncMessage invocations to execute after corresponding submitTransferRequests calls in two test sequences, deferring notification events until after transfer request submission completes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple test case reordering with no logic modifications
  • Changes are isolated to method call sequencing within test harness
  • No modifications to exported or public entity signatures

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is substantially incomplete. The author submitted only the template structure with empty comment placeholders for all critical sections (Description, Test Coverage, and PR Checklist items). The Description section lacks any explanation of what issue was being fixed or how the solution addresses it. The Test Coverage section provides no information about which tests safeguard these changes. The PR Checklist shows a checkmark but no evidence that the listed items were actually reviewed or applied to this specific change. This represents a largely incomplete submission that fails to meet the repository's documentation standards. The author should fill in the Description section with a clear explanation of why the test was failing and what the fix accomplishes. They should add specific test names or test paths to the Test Coverage section that validate these ordering changes. The PR Checklist items should be thoughtfully reviewed and either checked or left unchecked with justification. This additional context is necessary for reviewers to understand the motivation and scope of the changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[https://nvbugs/5612529][fix] Fix transferAgent_test" follows the required format with a valid NVBugs ID, correct type designation [fix], and a summary statement. The title is related to the changeset, which modifies the transferAgentTest.cpp file to fix ordering issues with sync messages and transfer requests. While the title doesn't capture the specific technical details of the fix (reordering of operations), it clearly communicates that something in the transferAgent test was corrected, which is meaningful enough for teammates scanning history to understand the general nature of the change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e36484 and 6523663.

📒 Files selected for processing (1)
  • cpp/tests/unit_tests/executor/transferAgentTest.cpp (2 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh}: Namespace closing braces must include a trailing comment with the namespace name (e.g., '} // namespace foo').
Prefer const or constexpr variables over #define for constants.
Declare variables that are not modified after initialization as const.
Avoid magic literals in code; except for 0, nullptr, true, false. Use named constants for comparisons and logic.
Use Allman brace style for formatting.
Place the semicolon of an empty for/while loop on a new line.
Bodies of switch/while/do-while/for must be compound statements (brace-delimited), and if/else must always be followed by brace-delimited statements.
Type names (e.g., classes) must be CamelCase starting with an uppercase letter (e.g., FooBar).
Local variables, methods, and namespaces use lowerCamelCase (e.g., localFooBar).
Non-magic-number global variables that are non-static and not in an anonymous namespace must be lowerCamelCase prefixed with 'g' (e.g., gDontUseGlobalFoos).
Non-magic-number globals that are static or in an anonymous namespace use lowerCamelCase prefixed with 's' (e.g., sMutableStaticGlobal).
Locally visible static variables use lowerCamelCase with 's' prefix (e.g., static std::once_flag sFlag).
Private/protected member variables use 'm' prefix with CamelCase (e.g., mNbFooValues). Public members may omit, but 'm' is encouraged for clarity.
Constants (enums, global constants, static constants, and function-scope magic/literal constants) use uppercase SNAKE_CASE with 'k' prefix (e.g., kDIGIT_NUM).
Function-scope constants that are not magic numbers or literals are named like non-constant variables (e.g., bool const pass = a && b).
If macros are necessary, name them in UPPER_SNAKE_CASE (e.g., FOO_VERSION) and prefer constants over #define.
Use LLVM clang-format; wrap lines at a maximum of 120 columns; use '// clang-format off/on' sparingly with justification.
Use smart pointers for heap allocations; prefer unique_ptr for sole ownership, shared_ptr for shared...

Files:

  • cpp/tests/unit_tests/executor/transferAgentTest.cpp
**/*.{cpp,cxx,cc,cu,h,hpp,hh,hxx,cuh}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

C++ filenames should be lowerCamelCase (first letter lowercase) and must be case-insensitive unique within a compilation target.

Files:

  • cpp/tests/unit_tests/executor/transferAgentTest.cpp
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • cpp/tests/unit_tests/executor/transferAgentTest.cpp
**/*.{h,hpp,hh,hxx,cpp,cxx,cc}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc}: Prefer anonymous namespaces over 'static' for internal linkage of functions.
All templates (class/function/member/static) must be instantiated at least once; non-POD classes should have private data members.

Files:

  • cpp/tests/unit_tests/executor/transferAgentTest.cpp
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • cpp/tests/unit_tests/executor/transferAgentTest.cpp
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (2)
cpp/tests/unit_tests/executor/transferAgentTest.cpp (2)

311-313: Consistent fix applied to second transfer sequence.

This change mirrors the fix at line 264, ensuring both transfer sequences in the test follow the same corrected ordering: submit transfer requests first, then notify sync messages. The consistency is good.

The empty line 313 appears to be a formatting adjustment.

263-264: Approved: reordering ensures proper temporal ordering of transfer submission and sync notification.

The change to submit the transfer request before notifying the sync message is correct and fixes a potential race condition. The reordering establishes the proper sequence: transfer initiation → sync notification → verify both complete.

The test intentionally uses a polling loop (lines 267–270, 315–318) for synchronization rather than explicit wait() calls used in other tests. This pattern blocks until sync messages are received, providing implicit synchronization before checking completion status. This is a valid alternative design for testing asynchronous transfer behavior.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Oct 28, 2025

PR_Github #22733 [ run ] triggered by Bot. Commit: 6523663

@tensorrt-cicd
Copy link
Collaborator

tensorrt-cicd commented Oct 28, 2025

PR_Github #22733 [ run ] completed with state SUCCESS. Commit: 6523663
/LLM/main/L0_MergeRequest_PR pipeline #17141 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@chuangz0 chuangz0 merged commit b828b64 into NVIDIA:main Oct 29, 2025
8 of 9 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
@chuangz0 @dominicshanshan
[https://nvbugs/5612529][fix] Fix transferAgent_test (NVIDIA#8710)
c22de76 
Signed-off-by: Chuang Zhu <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
@chuangz0 @dominicshanshan
[https://nvbugs/5612529][fix] Fix transferAgent_test (NVIDIA#8710)
448e257 
Signed-off-by: Chuang Zhu <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
@chuangz0 @dominicshanshan
[https://nvbugs/5612529][fix] Fix transferAgent_test (NVIDIA#8710)
7307f8a 
Signed-off-by: Chuang Zhu <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
@chuangz0 @dominicshanshan
[https://nvbugs/5612529][fix] Fix transferAgent_test (NVIDIA#8710)
e314178 
Signed-off-by: Chuang Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chuangz0 @tensorrt-cicd @Shixiaowei02